[Spice-devel] [PATCH] Use Python 2 for spice_codegen.py

[Alexander Wauck]

I was thinking it would be too much work to update to python3, especially if we wanted to keep python2 compatibility, but I took another look at it today, and the situation looks better than I thought.  I just ran 2to3 on the stuff in python_modules, and I only needed to do a few cleanups related to str vs. bytes and str vs. unicode.  I'm fairly certain that's all that's needed to make it work, but I don't know how much code my quick test covered (also not sure about 2.5 compat).  I'll send out that patch in a bit.

On Thu, 26 Mar 2015 09:57:20 +0100
Christophe Fergeau <cfergeau at redhat.com> wrote:

> Hey,
> 
> On Wed, Mar 25, 2015 at 03:44:25PM -0500, Alexander Wauck wrote:
> > Spice fails to compile on Arch Linux because spice_codegen.py uses "python"
> > rather than "python2".  PEP-394 suggests that the existence of "python2" is
> > something that we can rely on, although I am somewhat concerned about older
> > systems.
> 
> EL5.11 has python2, so does EL6, hopefully it's safe to assume that
> anything newer than that will have it too. Moreover, when building from
> tarball, spice_codegen.py should not be needed, so ACK (though ideally
> spice_codegen.py would get fixed for python3 too ;)
> 
> Christophe
> 
> > 
> > Signed-off-by: Alexander Wauck <awauck at codeweavers.com>
> > ---
> >  spice_codegen.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/spice_codegen.py b/spice_codegen.py
> > index c8376cc..9d5ff05 100755
> > --- a/spice_codegen.py
> > +++ b/spice_codegen.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python2
> >  
> >  import os
> >  import sys
> > -- 
> > 2.3.4
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel