[Spice-devel] [spice-protocol PATCH v3] volume-sync: spice-protocol, spice-gtk and linux-vdagent

[Victor Toso]

On Fri, Mar 27, 2015 at 12:31:56PM -0400, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
> > > > Right, but is it race free when you just start a session? Couldn't you
> > > > try
> > > > to get the current volume while it's not been yet received?
> > >
> > > You got me here, I'm not sure about this. AFAIK as spice-pulse uses
> > > glib-mainloop it should be in the same context, right? I'll take a
> > > better look into this.
> >
> > I don't think it may lead to race problems as the call to get volume and
> > the volume update are handled in the same glib-mainloop.
>
> It's not about thread races here, it's about concurrency. You could still
> be trying to read values that aren't yet received.

Ah, okay. I see it know. I think it wouldn't hurt to check the local
stream.volume, if it wasn't updated yet even if the stream was created
the call should just fail.

Thanks! Anything else you see that could be problematic?