[Spice-devel] [spice-gtk PATCH v4 0/6] volume-sync - spice-gtk updates

[Victor Toso]

On Mon, Mar 30, 2015 at 07:33:09AM -0400, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
> > spice-gtk v4:
> >
> > pulseaudio:
> > - Is possible to retrieve stream volume/mute values by using stream-restore
> > [0] API.
> >   This is also async and in my environemnt is slower then when the call to
> >   get this values
> >   happens;
>
> Isn't this redundant with subscribing to volume events?

This is done only once in order to get the last volume/mute/channels
value of each stream. The main pourpose of it is when we want to
volume-sync when the client connects.

The volume events are handy for all the other volume-sync possibilities
like migration. Without it, we may send the wrong value to the guest.

> > channel-main:
> > - use g_idle_add in audio-sync functions to work around the delay of getting
> > this values of pulseaudio. This is not significantly high in my enviroment
> > (three function calls). Using gstreamer backend it did not fail as it start
> > the pipeline to get the values.
>
> What's the guarantee that volume has been received when that idle is run?

Well, you are right. If gstreamer/pulse backend fails for whatever
reason this will not stop. Do you think a trying a fix number of times
is fine?

Thanks once again for the review :-)