[Spice-devel] [PATCH spice-gtk 0/5] audio fixes

Victor Toso victortoso at redhat.com
Wed May 6 08:39:29 PDT 2015


Hi,

On Wed, Apr 29, 2015 at 05:06:43PM +0200, Marc-André Lureau wrote:
> Hi
> 
> The following series of patches solves a crash happening when a record
> channel is reset but the audio session is still running (this may
> happen when the SpiceSession is recycled, and the stop signals didn't
> stop audio task yet). It also removes warnings when the audio channel is
> session-less (after it is detached from the session).

Only the playback-stop seems odd to me, everything else seems okay

> 
> Marc-André Lureau (5):
>   audio: emit stop when the channels are reset
>   playback: do not set mm time when session-less
>   record: do not crash after record is stopped
>   audio: use swapped channel handler for stop
>   audio: stop playback on channel destroyed
> 
>  gtk/channel-playback.c | 12 ++++++++++--
>  gtk/channel-record.c   | 13 ++++++++++---
>  gtk/spice-gstaudio.c   |  9 +++++----
>  gtk/spice-pulse.c      |  7 ++++---
>  4 files changed, 29 insertions(+), 12 deletions(-)
> 
> -- 
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list