[Spice-devel] [PATCH spice-gtk 1/5] audio: emit stop when the channels are reset

[Victor Toso]

Hi,

On Wed, May 06, 2015 at 12:44:26PM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > Hi,
> > 
> > On Wed, Apr 29, 2015 at 05:06:44PM +0200, Marc-André Lureau wrote:
> > > Ensure a hint is given to the client that the channel is reset.
> > >
> > > Unfortunately, since the handle may be asynchronous due to coroutine,
> > > the channel functions should be tolerant to a playback/record calls
> > > functions when the channel is stopped.
> > 
> > So, is it expected the audio to stop (briefly) on channel reset?
> > Did you this change on migration with audio playing?
> 
> On non-seamless migration, this is not an issue. Playback will be stopped and restarted.
> 
> On seamless migration, the migration session is different from the main session. The audio manager is only watching channels in the main session: channel-reset or destroy is not reached in this session during migration. I have tried to verify this locally with a simple test while playing music, unfortunately, qemu takes forever to migrate (remaining ram fluctuates between 8mb and 20mb).

I'll test here as well to help; I share the image on nfs which makes the
migration in the local network not so painful.