[Spice-devel] [PATCH v2 0/3] Fix Mac OS spice client build

[Fabiano Fidêncio]

Kirill,

On Sun, May 10, 2015 at 5:47 PM, Kirill Moizik <kirill at daynix.com> wrote:
> From: Kirill Moizik <kmoizik at redhat.com>
>
> Hi All,
> We tried to build mac client (gtk3 based) on Mavericks OS. It didn't worked from the box, so we did couple fixes to build process.
> Since we are running mac on vm, we had a chance to verify those patches works on clean machine.
> Now build process should be very easy and  can be done in a few steps.
>
> curl http://cgit.freedesktop.org/~teuf/spice-jhbuild/plain/spice-osx-build-setup.sh?h=osx > spice-osx-build-setup.sh
> sh ./spice-osx-build-setup.sh
> jhbuild bootstrap
> jhbuild build
>
> Please note : patch 0001 changing default from gtk2 to gtk3, since it seems most development will be focused on gtk3
> Thanks in advance,
> Kirill
>
> changeset:
> liboil build fix dissmissed - already fixed in gtk-osx upstream
> cups repo link fix patch sent to gtk-osx
> unnecesarry patches were dissmissed
>
> Kirill Moizik (3):
>   jhbuildrc: switch default from gtk2 to gtk3
>   jhbuildrc: fix autogen flags for cmake
>   spice-osx-build-setup.sh: fix gtk-osx fetching script link
>
>  jhbuildrc                | 6 ++++--
>  spice-osx-build-setup.sh | 2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)
>

Thanks for taking a look on the OSX client.

I have a some doubts not exactly related to your patches.
Did you update the repo spice.xml file? If not, why? Seems that you're
building virt-viewer 0.5.7 (last release is 2.0 and I have the feeling
we are not very far from a 3.0 release). Same comment applies for all
dependencies, as seems they are quite outdated.
Apart from that, what do we need to have USB redirection working on OS X?

Victor sent a bunch of patches updating the spice-jhbuild repo (for
linux) that could be (re)used for the OS X branch.

Would be super if we can have the packages built matching the same
versions (or similar to) that we have on latest Fedora (22).

Best Regards,
-- 
Fabiano Fidêncio