[Spice-devel] [PATCH v2 1/3] jhbuildrc: switch default from gtk2 to gtk3

[Victor Toso]

Hi,

On Sun, May 10, 2015 at 06:47:31PM +0300, Kirill Moizik wrote:
> From: Kirill Moizik <kmoizik at redhat.com>
>
> change default modules from modules using gtk2 to modules using gtk3

As Fabiano mentioned, the requirements for virt-viewer-gtk3 and
virt-viewer (gtk2) could go in the moduleset as buildep. JHBuild would
fetch and build them. So one could have gtk2 and gtk3 version by having:
modules = [ "virt-viewer", "virt-viewer-gtk3" ]

> Signed-off-by: Kirill Moizik <kmoizik at redhat.com>
> ---
>  jhbuildrc | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/jhbuildrc b/jhbuildrc
> index b1873c3..403ef43 100644
> --- a/jhbuildrc
> +++ b/jhbuildrc
> @@ -9,10 +9,11 @@ prefix = os.path.join(_root, "inst")
>  
>  # spice gtk-osx moduleset
>  moduleset = 'http://cgit.freedesktop.org/~teuf/spice-jhbuild/plain/modulesets/spice.xml?h=osx'

I believe this should point to the local moduleset/spice.xml

> -modules = [ "meta-gtk-osx-bootstrap", "meta-gtk-osx-core", "virt-viewer" ]
> +#for a gtk2 build use these modules
> +#modules = [ "meta-gtk-osx-bootstrap", "meta-gtk-osx-core", "virt-viewer" ]
>  skip.append('libiconv')
>  #for a gtk3 build use these modules
> -#modules = [ "meta-gtk-osx-bootstrap", "meta-gtk-osx-gtk3", "virt-viewer-gtk3" ]
> +modules = [ "meta-gtk-osx-bootstrap", "meta-gtk-osx-gtk3", "virt-viewer-gtk3" ]
>  #I've seen introspection generation totally hang during gtk+3 builds.
>  #We don't need .gir to build virt-viewer, so let's disable introspection
>  #altogether
> -- 
> 1.9.5 (Apple Git-50.3)
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel