[Spice-devel] [spice-common][PATCH 1/2] ppc: Deal with lz magic endianess

Christophe Fergeau cfergeau at redhat.com
Mon May 18 09:13:15 PDT 2015


On Mon, May 18, 2015 at 03:10:57PM +0200, Fabiano FidĂȘncio wrote:
> Since commit d39dfbfe lz magic is always treated as LE when encoded.
> Treating it as a LE when decoding is now necessary as well.

Thanks for the catch. The issue is that given the way LZ_MAGIC is
defined in lz_common.h, it will have a different value when running on a
big-endian or on a little-endian system. decode_32/encode_32 try to
handle endianness on their own, but in the case of LZ_MAGIC, we don't
want this special treatment to happen, so we need an extra endian swap.
I assume this is what you mean when you say we want to treat it as LE in
the log?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150518/9b234c39/attachment.sig>


More information about the Spice-devel mailing list