[Spice-devel] [spice-gtk][PATCH 4/4] ppc: Fix auth endianess

Christophe Fergeau cfergeau at redhat.com
Mon May 18 09:58:38 PDT 2015


On Mon, May 18, 2015 at 03:11:08PM +0200, Fabiano FidĂȘncio wrote:
> ---
>  gtk/spice-channel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
> index 0da377b..273cf3a 100644
> --- a/gtk/spice-channel.c
> +++ b/gtk/spice-channel.c
> @@ -1750,14 +1750,14 @@ static gboolean spice_channel_recv_link_msg(SpiceChannel *channel)
>  #if HAVE_SASL
>          if (spice_channel_test_common_capability(channel, SPICE_COMMON_CAP_AUTH_SASL)) {
>              CHANNEL_DEBUG(channel, "Choosing SASL mechanism");
> -            auth.auth_mechanism = SPICE_COMMON_CAP_AUTH_SASL;
> +            auth.auth_mechanism = GUINT32_TO_LE(SPICE_COMMON_CAP_AUTH_SASL);
>              spice_channel_write(channel, &auth, sizeof(auth));
>              if (!spice_channel_perform_auth_sasl(channel))
>                  return FALSE;
>          } else
>  #endif
>          if (spice_channel_test_common_capability(channel, SPICE_COMMON_CAP_AUTH_SPICE)) {
> -            auth.auth_mechanism = SPICE_COMMON_CAP_AUTH_SPICE;
> +            auth.auth_mechanism = GUINT32_TO_LE(SPICE_COMMON_CAP_AUTH_SPICE);
>              spice_channel_write(channel, &auth, sizeof(auth));
>              spice_channel_send_spice_ticket(channel);
>          } else {
> -- 

ACK, though my feeling by looking for spice_channel_read() occurrences
throughout this file is that there may be some more work to do for SASL
auth to work.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150518/e8915f23/attachment.sig>


More information about the Spice-devel mailing list