[Spice-devel] [spice-gtk PATCH v2 1/5] giopipe: don't fail on create_source

Victor Toso victortoso at redhat.com
Tue May 19 07:34:33 PDT 2015


PipeInputStream and PipeOutputStream should not fail when creating
GPollableStream source. It is already checked and unref in case of
existing source.
---
 gtk/giopipe.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/gtk/giopipe.c b/gtk/giopipe.c
index 440cae9..32fa4fa 100644
--- a/gtk/giopipe.c
+++ b/gtk/giopipe.c
@@ -234,9 +234,6 @@ pipe_input_stream_create_source (GPollableInputStream *stream,
     PipeInputStream *self = PIPE_INPUT_STREAM(stream);
     GSource *pollable_source;
 
-    g_return_val_if_fail (self->source == NULL ||
-                          g_source_is_destroyed (self->source), NULL);
-
     if (self->source && g_source_is_destroyed (self->source))
         g_source_unref (self->source);
 
@@ -416,9 +413,6 @@ pipe_output_stream_create_source (GPollableOutputStream *stream,
     PipeOutputStream *self = PIPE_OUTPUT_STREAM(stream);
     GSource *pollable_source;
 
-    g_return_val_if_fail (self->source == NULL ||
-                          g_source_is_destroyed (self->source), NULL);
-
     if (self->source && g_source_is_destroyed (self->source))
         g_source_unref (self->source);
 
-- 
2.4.1



More information about the Spice-devel mailing list