[Spice-devel] [spice-gtk][PATCH] spicy: Fix error msg dialog created without parent

[Lukas Venhoda]

Spicy creates it's first window only after connection has been
established (window = display). This makes it currenlty impossible to
supply parent window to connection dialog.

Supplying a fake parent will sqeulch the error message.
Possible fix for fdo#90452
---
 gtk/spicy.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gtk/spicy.c b/gtk/spicy.c
index 9cd6ee5..d1ff1c1 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -223,13 +223,15 @@ static void recent_item_activated_dialog_cb(GtkRecentChooser *chooser, gpointer

 static int connect_dialog(SpiceSession *session)
 {
-    GtkWidget *dialog, *area, *label;
+    GtkWidget *dialog, *area, *label, *fake_parent;
     GtkTable *table;
     int i, retval;

+    fake_parent = gtk_window_new(GTK_WINDOW_TOPLEVEL);
+
     /* Create the widgets */
     dialog = gtk_dialog_new_with_buttons(_("Connect to SPICE"),
-                                         NULL,
+                                         fake_parent,
                                          GTK_DIALOG_DESTROY_WITH_PARENT,
                                          GTK_STOCK_CANCEL,
                                          GTK_RESPONSE_REJECT,
@@ -291,6 +293,7 @@ static int connect_dialog(SpiceSession *session)
     } else
         retval = -1;
     gtk_widget_destroy(dialog);
+    gtk_widget_destroy(fake_parent);
     return retval;
 }

--
2.4.1