[Spice-devel] [spice-gtk PATCH v2 3/5] tests: read8_cb expects GMainLoop as user_data

[Marc-André Lureau]

Hi

On Tue, May 19, 2015 at 4:34 PM, Victor Toso <victortoso at redhat.com> wrote:

> ---
>  tests/pipe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/pipe.c b/tests/pipe.c
> index 841cb77..ead8c99 100644
> --- a/tests/pipe.c
> +++ b/tests/pipe.c
> @@ -179,7 +179,7 @@ test_pipe_write16read8(Fixture *f, gconstpointer
> user_data)
>      g_output_stream_write_async(f->op1, "0123456789abcdef", 16,
> G_PRIORITY_DEFAULT,
>                                  f->cancellable, write_cb, f->loop);
>      g_input_stream_read_async(f->ip2, f->buf, 8, G_PRIORITY_DEFAULT,
> -                              f->cancellable, read8_cb,
> GINT_TO_POINTER(8));
> +                              f->cancellable, read8_cb, f->loop);
>
>      g_main_loop_run (f->loop);
>
> @@ -193,7 +193,7 @@ test_pipe_write8read16(Fixture *f, gconstpointer
> user_data)
>      g_output_stream_write_async(f->op1, "01234567", 8, G_PRIORITY_DEFAULT,
>                                  f->cancellable, write_cb, f->loop);
>      g_input_stream_read_async(f->ip2, f->buf, 16, G_PRIORITY_DEFAULT,
> -                              f->cancellable, read8_cb,
> GINT_TO_POINTER(8));
> +                              f->cancellable, read8_cb, f->loop);
>
>
loop is not used though. I think my intention was to have a generic read_cb
instead of hardcoding the 8 bytes read.

     g_main_loop_run (f->loop);
>
> --
> 2.4.1
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150520/7a0dad2d/attachment.html>