[Spice-devel] [PATCH 13/13] moduleset: Update dependencies

[Victor Toso]

Hi, thanks for the review

On Tue, May 12, 2015 at 04:41:55PM +0200, Christophe Fergeau wrote:
> On Thu, Apr 30, 2015 at 06:59:14PM +0200, Victor Toso wrote:
> > ---
> >  modulesets/spice.xml | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/modulesets/spice.xml b/modulesets/spice.xml
> > index 589b250..6b0180f 100644
> > --- a/modulesets/spice.xml
> > +++ b/modulesets/spice.xml
> > @@ -85,6 +85,9 @@
> >    <autotools id="spice-gtk">
> >      <branch repo="spice" module="spice-gtk.git"/>
> >      <dependencies>
> > +      <dep package="gtk+"/>
> > +      <dep package="gst-plugins-good"/>
>
> Hmm, if I'm not mistaken, this is now going to build
> gtk+/gst-plugins-good from git through jhbuild rather than using the
> ones on the system? I'd tend to prefer the more lightweight approach of
> not having to rebuild the gtk+ stack.

True. Other changes I did makes it build more then it perhaps should.
I'll remove those.

> > +      <dep package="phodav"/>
> 
> This one could be added at the same time as the phodav commit

Sure

> Christophe