[Spice-devel] [PATCH xf86-qxl 1/2] kms: initialize primary surface to screen virtual size

[Christophe Fergeau]

ACK series, I haven't tested the first one, I've checked that the second
one. Can you expand a bit on what the "rendering glitches" are if that's
easy? I'd mention explicitly that there's a crash in the second patch
log.

Christophe

On Wed, May 13, 2015 at 07:12:17PM +0200, Marc-André Lureau wrote:
> The pScrn->virtualX/Y are set after drmmode_pre_init(), use that
> resolution instead of hard-coded 1024x768.
> 
> This fixes rendering glitches when restarting X server with
> different primary size than actual monitor modes.
> ---
>  src/qxl_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qxl_kms.c b/src/qxl_kms.c
> index c31c62d..b6952f3 100644
> --- a/src/qxl_kms.c
> +++ b/src/qxl_kms.c
> @@ -164,8 +164,8 @@ Bool qxl_pre_init_kms(ScrnInfoPtr pScrn, int flags)
>      if (drmmode_pre_init(pScrn, &qxl->drmmode, pScrn->bitsPerPixel / 8) == FALSE)
>        goto out;
>  
> -    qxl->virtual_x = 1024;
> -    qxl->virtual_y = 768;
> +    qxl->virtual_x = pScrn->virtualX;
> +    qxl->virtual_y = pScrn->virtualY;
>      
>      pScrn->display->virtualX = qxl->virtual_x;
>      pScrn->display->virtualY = qxl->virtual_y;
> -- 
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150522/b122650e/attachment.sig>