[Spice-devel] [PATCH 1/5] build: add build option for non-winusb redirection backends

[Dmitry Fleytman]

> On May 28, 2015, at 17:58 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> 
> Hey,
> 
> On Thu, May 28, 2015 at 01:24:00PM +0300, Kirill Moizik wrote:
>> From: Dmitry Fleytman <dmitry at daynix.com>
>> 
>> --enable-winusb configure option added
>> 
>> This option actually disables winusb driver installation
>> for the USB device being redirected.
> 
> I'm a bit confused by this option. After the patch series, usbdk support
> is dynamically enabled through the use of a 'use_usbdk' boolean, which
> is set this way:
> 
> #ifdef USE_WINUSB
>    use_usbdk = is_usbdk_driver_installed();
> 
>    if(use_usbdk) {
>        if (usbdk_api_load(&priv->usbdk_api) == -1) {
>            SPICE_DEBUG("Failed to load UsbDk API DLL");
>        }
>    }
> #endif
> 
> so --disable-winusb will disable both UsbDk and Usbclerk support. Are there
> cases when we want to disable this support?

Hi Christophe, thanks for pointing out. It looks like this is something we missed.

The original idea behind that patch was that UsbDk/usbclerk selection would be done on compile time.
After that we introduced dynamic backend selection mechanism which actually invalidated this patch’s logic.

We will drop this patch in V2.

> 
> Christophe