[Spice-devel] red_dispatcher: client disconnect hangs the server

[Anton D. Kachalov]

Hell, Christophe.

I've found a missed mutex unlock in my code added to the red_worker/fill_bits. Git version looks stable for me now.

03.11.2015, 18:24, "Christophe Fergeau" <cfergeau at redhat.com>:
> Hey,
>
> On Thu, Oct 29, 2015 at 08:54:12PM +0300, Anton D. Kachalov wrote:
>>  Hi.
>>
>>  I often get stucked on client disconnect on blocking read (recent git checkout):
>
> git master is moving quite a lot currently, I'd recommend sticking to
> the 0.12.6 tag for now. If you want to stay up to date on latest git
> master, reporting the issues you find there is very welcome!
>
> Christophe
>
>>  #0 0x00007fb6049bd3bd in read () at ../sysdeps/unix/syscall-template.S:81
>>  #1 0x00007fb604efb1c4 in read (__nbytes=4, __buf=0x7fff4cf978a4, __fd=10) at /usr/include/x86_64-linux-gnu/bits/unistd.h:44
>>  #2 read_safe (fd=fd at entry=10, buf=buf at entry=0x7fff4cf978a4 "", size=size at entry=4, block=block at entry=1) at dispatcher.c:76
>>  #3 0x00007fb604efb697 in dispatcher_send_message (dispatcher=dispatcher at entry=0x87ae48, message_type=message_type at entry=6,
>>      payload=payload at entry=0x7fff4cf978e0) at dispatcher.c:191
>>  #4 0x00007fb604efc4c5 in red_dispatcher_disconnect_display_peer (rcc=0x7fb6053ba010) at red_dispatcher.c:131
>>  #5 0x00007fb604ef9fa4 in red_client_destroy (client=client at entry=0x894c50) at red_channel.c:2157
>>  #6 0x00007fb604f29cb3 in reds_client_disconnect (client=0x894c50) at reds.c:478
>>  #7 0x00007fb604efeb49 in main_dispatcher_handle_client_disconnect (opaque=<optimized out>, payload=0x8722a0) at main_dispatcher.c:139
>>  #8 0x00007fb604efb4a8 in dispatcher_handle_single_read (dispatcher=0x7fb60521c9c0 <main_dispatcher>) at dispatcher.c:142
>>  #9 dispatcher_handle_recv_read (dispatcher=0x7fb60521c9c0 <main_dispatcher>) at dispatcher.c:165
>>  #10 0x0000000000401e4a in watch_func (source=<optimized out>, condition=<optimized out>, data=0x870470) at basic_event_loop.c:128
>>  #11 0x00007fb604c14ce5 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
>>  #12 0x00007fb604c15048 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
>>  #13 0x00007fb604c1530a in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
>>  #14 0x0000000000401f95 in basic_event_loop_mainloop () at basic_event_loop.c:173
>>  #15 0x0000000000401bfc in main () at test_display_no_ssl.c:86
>>
>>  --
>>  Anton D. Kachalov
>>  _______________________________________________
>>  Spice-devel mailing list
>>  Spice-devel at lists.freedesktop.org
>>  http://lists.freedesktop.org/mailman/listinfo/spice-devel

-- 
Anton D. Kachalov

ITO, System Architect
Tel: 7 (495) 739-70-00 ext.7613