[Spice-devel] [common PATCH 8/8 v3] ppc: Fix alpha state checking and clearing on BE machines

Christophe Fergeau cfergeau at redhat.com
Thu Nov 5 09:31:45 PST 2015


On Thu, Nov 05, 2015 at 11:03:56AM +0100, Lukas Venhoda wrote:
> Hi
> 
> On Mon, Oct 26, 2015 at 2:19 PM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > On Thu, Oct 22, 2015 at 05:02:54PM +0200, Lukas Venhoda wrote:
> > > When checking, whether we use alpha channel, we need to compare color
> > > format with constant with the same byte order.
> > >
> > > When clearing alpha channel, we must clear in proper byte order.
> >
> > Regarding cleanup of alpha channel, there is clear_dest_alpha() in
> > sw_canvas.c, is it all fine with respect to endianness handling?
> >
> > Christophe
> >
> 
> Just tried this, and clear_dest_alpha() is endianess safe.
> It is clearing the alpha before LE to BE conversion,
> so it stays the same on BE machine.


Ok, thanks!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151105/d6318165/attachment.sig>


More information about the Spice-devel mailing list