[Spice-devel] [PATCH 4/5] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

Fabiano FidĂȘncio fidencio at redhat.com
Wed Nov 11 05:20:14 PST 2015


On Wed, Nov 11, 2015 at 2:09 PM, Pavel Grunt <pgrunt at redhat.com> wrote:
> On Wed, 2015-11-11 at 00:37 +0100, Fabiano FidĂȘncio wrote:
>> On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
>> > ---
>> >  server/red_worker.c | 1 -
>> >  1 file changed, 1 deletion(-)
>> >
>> > diff --git a/server/red_worker.c b/server/red_worker.c
>> > index dd4633c..8a2ff0e 100644
>> > --- a/server/red_worker.c
>> > +++ b/server/red_worker.c
>> > @@ -75,7 +75,6 @@
>> >  #define CMD_RING_POLL_RETRIES 200
>> >
>> >  #define DISPLAY_CLIENT_SHORT_TIMEOUT 15000000000ULL //nano
>> > -#define DISPLAY_CLIENT_TIMEOUT 30000000000ULL //nano
>> >  #define DISPLAY_CLIENT_MIGRATE_DATA_TIMEOUT 10000000000ULL //nano, 10 sec
>> >  #define DISPLAY_CLIENT_RETRY_INTERVAL 10000 //micro
>> >
>> > --
>> > 2.4.3
>> >
>> > _______________________________________________
>> > Spice-devel mailing list
>> > Spice-devel at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>> As DISPLAY_CLIENT_TIMEOUT is only used in red_worker.c I would keep
>> the define there and remove the one from server/red_worker.h
> It is also used in server/cursor-channel.c

Oh, I missed that one. ACK then!

>
> Pavel
>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list