[Spice-devel] [PATCH 09/11] Move dcc_create_stream to display channel

[Frediano Ziglio]

> 
> On Mon, 2015-11-16 at 13:20 +0100, Pavel Grunt wrote:
> > Hi,
> > 
> > it is not moved, it is just making it public. Can it be moved from
> > red_worker.c?
> 
> 
> Yeah, this is another commit that I debated whether to separate or not, and
> also
> debated whether to actually move the implementation to display_channel.c. But
> in
> the end I decided not to move it to avoid making future rebases more
> difficult.
> I believe it will end up being moved in a later commit anyway. We can just
> fold
> this commit back into another one if you'd like.
> 

I honestly prefer to invest more time and get things right.
I don't like to have regressions to be fixed later for sure and
this should apply to every single patch.

To be specific to this patch I agree with Pavel too. The
patch is not doing what is saying.
The function is moved in "859aff87017131b6d561c718fb53c4ab0bebaa0b worker: move stream_agent_stop and friends".
I don't think is too difficult to backport this move change in this patch and merging
the change to public with a move make also sense.
I'll try to change the patch!

Frediano

> 
> > 
> > Pavel
> > 
> > On Mon, 2015-11-16 at 11:06 +0000, Frediano Ziglio wrote:
> > > From: Jonathon Jongsma <jjongsma at redhat.com>
> > > 
> > > ---
> > >  server/display-channel.h | 2 ++
> > >  server/red_worker.c      | 2 +-
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/server/display-channel.h b/server/display-channel.h
> > > index edbd4b9..ae8a900 100644
> > > --- a/server/display-channel.h
> > > +++ b/server/display-channel.h
> > > @@ -252,6 +252,8 @@
> > > void                       dcc_push_destroy_surface
> > >  (DisplayC
> > > ha
> > >                                                                       
> > >  uint32_
> > > t surface_id);
> > >  void                       dcc_add_stream_agent_clip
> > >  (Display
> > > ChannelClient* dcc,
> > >                                                                       
> > >  StreamA
> > > gent *agent);
> > > +void                       dcc_create_stream
> > >  (Display
> > > ChannelClient *dcc,
> > > +
> > >  Stream
> > > *stream);
> > >  
> > >  typedef struct DrawablePipeItem {
> > >      RingItem base;  /* link for a list of pipe items held by Drawable */
> > > diff --git a/server/red_worker.c b/server/red_worker.c
> > > index a5abe87..e63828b 100644
> > > --- a/server/red_worker.c
> > > +++ b/server/red_worker.c
> > > @@ -1479,7 +1479,7 @@ static void
> > > red_stream_update_client_playback_latency(void *opaque, uint32_t del
> > >      main_dispatcher_set_mm_time_latency(RED_CHANNEL_CLIENT(agent->dcc)-
> > > > client, agent->dcc->streams_max_latency);
> > >  }
> > >  
> > > -static void dcc_create_stream(DisplayChannelClient *dcc, Stream *stream)
> > > +void dcc_create_stream(DisplayChannelClient *dcc, Stream *stream)
> > >  {
> > >      StreamAgent *agent =
> > >      &dcc->stream_agents[get_stream_id(DCC_TO_DC(dcc),
> > > stream)];
> > >  
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
>