[Spice-devel] [NSIS 04/13] Remove EXE_VERSION

Yedidyah Bar David didi at redhat.com
Thu Nov 19 06:48:14 PST 2015


From: Christophe Fergeau <cfergeau at redhat.com>

This is only used when generating the oVirt installer as it does not
want any version number to be included in the .exe filename provided on
the ISO it ships. However, if someone was to ship a standalone .exe
outside of an ISO, an unversioned installer executable is not what
is expected. This commit removes EXE_VERSION, the installer executable
will be "unversioned" at ISO time generation instead.

Change-Id: Iaa3263aa7d26f39f073db058a6138728c09e12c4
Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
---
 win-guest-tools.nsis | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
index 23c068d..9d289ad 100644
--- a/win-guest-tools.nsis
+++ b/win-guest-tools.nsis
@@ -63,13 +63,10 @@ SetCompressor /SOLID lzma
 !ifndef DISPLAYED_VERSION
 !define DISPLAYED_VERSION "${VERSION}"
 !endif
-!ifndef EXE_VERSION
-!define EXE_VERSION "-${VERSION}"
-!endif
 
 Name "${NAME}"
 Caption "${NAME} Installer"
-OutFile "${FILENAME}${EXE_VERSION}.exe"
+OutFile "${FILENAME}-${VERSION}.exe"
 InstallDir "$PROGRAMFILES\${NAME}"
 BrandingText "${BRANDINGTEXT}"
 
-- 
2.1.4



More information about the Spice-devel mailing list