[Spice-devel] [PATCH 2/2] worker: change spice_assert in handle_dev_stop

Frediano Ziglio fziglio at redhat.com
Fri Nov 20 02:35:01 PST 2015


> 
> NACK, I don't see a reason for changing it.
> 
> Pavel
> 
> On Thu, 2015-11-19 at 18:01 +0000, Frediano Ziglio wrote:
> > From: Marc-André Lureau <marcandre.lureau at gmail.com>
> > 
> > ---
> >  server/red_worker.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index 747bb9e..f6023bb 100644
> > --- a/server/red_worker.c
> > +++ b/server/red_worker.c
> > @@ -6150,7 +6150,7 @@ static void handle_dev_stop(void *opaque, void
> > *payload)
> >      RedWorker *worker = opaque;
> >  
> >      spice_info("stop");
> > -    spice_assert(worker->running);
> > +    spice_return_if_fail(worker->running);
> >  
> >      worker->running = FALSE;
> >  
> 

Rejected

Frediano


More information about the Spice-devel mailing list