[Spice-devel] [PATCH spice-server 00/15] Remove unused functions

[Victor Toso]

Hi,

On Fri, Nov 20, 2015 at 11:47:41AM +0100, Pavel Grunt wrote:
> On Fri, 2015-11-20 at 04:32 -0500, Frediano Ziglio wrote:
> > > 
> > > Hi,
> > > 
> > > I noticed that there are some unused functions in our code.
> > > Some of them were just defined, but haven't been used, others
> > > stopped being used because some other functions were changed/removed.
> > > I'm not sure about last 3-4 patches - if _create() is called then
> > > it would make sense to call _destroy() too - I will investigate more.
> > > 
> > > Thanks,
> > > Pavel
> > > 
> > 
> > Hi Pavel,
> >    please do not remove any *_destroy or cleanup (like stat_remove_*)
> > function. I'll have a branch that will allow to cleanup everything.
> > Is useful (I used and uses sometimes) to detect leaks and I would like
> > to implement some lazy allocation to reduce memory footprint when clients
> > are not connected so I need to free resources at some times.
> > 
> > Frediano
> Hi Frediano,
> 
> Thanks for the reply, I will not push the patches. I wasn't sure whether I
> should send the last 3-4 patches, but I decided to do it to show the issue and
> get some answers / advices.
> 
> Pavel

Now that you are using these  _destroy, can you resend the series?
It is always good to remove dead code ;)

Cheers,
  - toso