[Spice-devel] spice-server, logging and style

Christophe Fergeau cfergeau at redhat.com
Fri Nov 20 10:07:32 PST 2015


On Fri, Nov 20, 2015 at 01:01:30PM -0500, Frediano Ziglio wrote:
> > 
> > On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> > > Problems:
> > > - the Spice_style.odt is outdated;
> > > - spice_assert recall the standard assert but instead it mainly
> > >   call spice_error which like GLib is fatal and should call exit/abort.
> > >   It is not affected by NDEBUG or other definitions. Why using it instead
> > >   of spice_error?
> > 
> > Note that spice-common has verify.h (from gnulib) which can be used for
> > truly static checks. I did not notice that there is a
> > spice_static_assert before ;)
> > 
> > Christophe
> > 
> 
> I think you are confusing static assertions here with dynamic ones.

verify.h does compile-time assertions, which is what I call 'static
assertions':

lz_common.h:62:1: erreur: static assertion failed: "verify (1 == 0)"
 verify(1 == 0);

 Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151120/b58a7848/attachment.sig>


More information about the Spice-devel mailing list