[Spice-devel] [PATCH spice-server v2 05/11] red channel: Remove unused red_channel_pipes_new_add_tail

[Fabiano Fidêncio]

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> It was introduced in 0f0bdb190b8586ef7ac20fcefffe641e44eb15b9
> but never used.

This case is exactly the same one of the last patch ...

>
> Signed-off-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/red_channel.c | 6 ------
>  server/red_channel.h | 1 -
>  2 files changed, 7 deletions(-)
>
> diff --git a/server/red_channel.c b/server/red_channel.c
> index 1c9cfc6..a57415e 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -2275,12 +2275,6 @@ void red_channel_pipes_new_add(RedChannel *channel, new_pipe_item_t creator, voi
>                                       red_channel_client_pipe_add);
>  }
>
> -void red_channel_pipes_new_add_tail(RedChannel *channel, new_pipe_item_t creator, void *data)
> -{
> -    red_channel_pipes_create_batch(channel, creator, data,
> -                                     red_channel_client_pipe_add_tail_no_push);
> -}
> -
>  uint32_t red_channel_max_pipe_size(RedChannel *channel)
>  {
>      RingItem *link;
> diff --git a/server/red_channel.h b/server/red_channel.h
> index 16e9976..4945e59 100644
> --- a/server/red_channel.h
> +++ b/server/red_channel.h
> @@ -477,7 +477,6 @@ void red_channel_pipe_item_init(RedChannel *channel, PipeItem *item, int type);
>  typedef PipeItem *(*new_pipe_item_t)(RedChannelClient *rcc, void *data, int num);
>  void red_channel_pipes_new_add_push(RedChannel *channel, new_pipe_item_t creator, void *data);
>  void red_channel_pipes_new_add(RedChannel *channel, new_pipe_item_t creator, void *data);
> -void red_channel_pipes_new_add_tail(RedChannel *channel, new_pipe_item_t creator, void *data);
>
>  void red_channel_client_pipe_add_push(RedChannelClient *rcc, PipeItem *item);
>  void red_channel_client_pipe_add(RedChannelClient *rcc, PipeItem *item);
> --
> 2.5.0
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Hmm. I know it's the same case as the previous patch, but I am not
sure if I agree on removing this kind of function just because it's
not used now ...

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>