[Spice-devel] [PATCH 01/18] worker: do not set worker image compression on client request

Frediano Ziglio fziglio at redhat.com
Tue Nov 24 01:12:11 PST 2015


> 
> On Mon, Nov 23, 2015 at 6:01 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
> > From: Marc-André Lureau <marcandre.lureau at gmail.com>
> >
> > Display client can ask to change the preferred compression.
> > Previously this setting change the entire worker setting
> > so every future client created would have this setting.
> > Remove the setting in the worker make the change local to
> > the client live.
> 
> (...) make the change only to the current client.
> 
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/red_worker.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index d3a675b..188cb16 100644
> > --- a/server/red_worker.c
> > +++ b/server/red_worker.c
> > @@ -4810,8 +4810,8 @@ static int
> > display_channel_handle_stream_report(DisplayChannelClient *dcc,
> >  }
> >
> >  static int
> >  display_channel_handle_preferred_compression(DisplayChannelClient *dcc,
> > -        SpiceMsgcDisplayPreferredCompression *pc) {
> > -    DisplayChannel *display_channel = DCC_TO_DC(dcc);
> > +        SpiceMsgcDisplayPreferredCompression *pc)
> > +{
> >      switch (pc->image_compression) {
> >      case SPICE_IMAGE_COMPRESSION_AUTO_LZ:
> >      case SPICE_IMAGE_COMPRESSION_AUTO_GLZ:
> > @@ -4822,7 +4822,6 @@ static int
> > display_channel_handle_preferred_compression(DisplayChannelClient *dc
> >      case SPICE_IMAGE_COMPRESSION_LZ:
> >      case SPICE_IMAGE_COMPRESSION_GLZ:
> >      case SPICE_IMAGE_COMPRESSION_OFF:
> > -        display_channel->common.worker->image_compression =
> > pc->image_compression;
> >          dcc->image_compression = pc->image_compression;
> >          return TRUE;
> >      default:
> > --
> > 2.4.3
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> Acked-by: Fabiano Fidêncio <fidencio at redhat.com>
> 

Merged

Frediano


More information about the Spice-devel mailing list