[Spice-devel] [PATCH] server: Remove unneeded asserts in mjpeg_encoder_get_stats()

[Christophe Fergeau]

On Mon, Nov 23, 2015 at 12:07:49PM -0500, Frediano Ziglio wrote:
> > 
> > No other function checks the 'this' pointer and if not given a buffer
> > to return the statistics we can simply not return any.
> > 
> > Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> > ---
> >  server/mjpeg_encoder.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > So following the logging discussion it looks like we would be going
> > towards using the g_return_xxx() functions so in
> > mjpeg_encoder_get_bit_rate()'s case we would get something like this.
> > Makes sense?
> > 
> 
> Ehm... no, NACK

Some rationale is needed so that Francois knows how to improve his
patch. Is the assert->return_if_fail change wrong and unwanted? Should
he use some other variant of return_if_fail?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151124/08b940f8/attachment.sig>