[Spice-devel] [PATCH 18/18] worker: remove redundant check

[Pavel Grunt]

On Tue, 2015-11-24 at 11:13 +0000, Frediano Ziglio wrote:
> From: Marc-André Lureau <marcandre.lureau at gmail.com>
> 
> The check is done in draw()
I don't see it in display_channel_draw(), it also prevented calling
notify_update().

I think the patch should be dropped.

Pavel

Reviewed-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/red_worker.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 4cc9fe9..a9fbd64 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -647,10 +647,6 @@ static int red_process_commands(RedWorker *worker,
> uint32_t max_pipe_size, int *
>                                     &update, ext_cmd.cmd.data)) {
>                  break;
>              }
> -            if (!validate_surface(worker->display_channel,
> update.surface_id)) {
> -                spice_warning("Invalid surface in QXL_CMD_UPDATE");
> -                break;
> -            }
>              display_channel_draw(worker->display_channel, &update.area,
> update.surface_id);
>              worker->qxl->st->qif->notify_update(worker->qxl,
> update.update_id);
>              release_info_ext.group_id = ext_cmd.group_id;