[Spice-devel] [PATCH 08/19] worker: remove redundant check

[Fabiano Fidêncio]

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau at gmail.com>
>
> The check is done in draw()
> ---
>  server/red_worker.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 84048fe..2b5c162 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -647,10 +647,6 @@ static int red_process_commands(RedWorker *worker, uint32_t max_pipe_size, int *
>                                     &update, ext_cmd.cmd.data)) {
>                  break;
>              }
> -            if (!validate_surface(worker->display_channel, update.surface_id)) {
> -                spice_warning("Invalid surface in QXL_CMD_UPDATE");
> -                break;
> -            }
>              display_channel_draw(worker->display_channel, &update.area, update.surface_id);
>              worker->qxl->st->qif->notify_update(worker->qxl, update.update_id);
>              release_info_ext.group_id = ext_cmd.group_id;
> --
> 2.4.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Please, someone correct-me if I am mistaken, but this check doesn't
seem to be done in the draw(). NAK from me.
Reviwed-by: Fabiano Fidêncio <fidencio at redhat.com>