[Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

[Fabiano Fidêncio]

On Thu, Nov 26, 2015 at 10:18 AM, Uri Lublin <uril at redhat.com> wrote:
> On 11/23/2015 09:39 PM, Jonathon Jongsma wrote:
>>
>> On Mon, 2015-11-23 at 13:33 -0600, Jonathon Jongsma wrote:
>>>
>>> Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
>>>
>>
>> I take it back.  This should probably be re-merged with the next patch.
>> See
>> below.
>>
>>>
>>>
>>> On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote:
>>>>
>>>> From: Marc-André Lureau <marcandre.lureau at gmail.com>
>>>>
>>>> ---
>>>>   server/red_worker.c | 8 ++++----
>>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/server/red_worker.c b/server/red_worker.c
>>>> index becd42f..efadd91 100644
>>>> --- a/server/red_worker.c
>>>> +++ b/server/red_worker.c
>>>> @@ -936,7 +936,7 @@ static void image_surface_init(DisplayChannel
>>>> *display)
>>>>       display->image_surfaces.ops = &image_surfaces_ops;
>>>>   }
>>>>
>>>> -static void validate_area(DisplayChannel *display, const SpiceRect
>>>> *area,
>>>> uint32_t surface_id)
>>>> +static void surface_update_dest(DisplayChannel *display, RedSurface
>>>> *surface,
>>>> const SpiceRect *area)
>>>>   {
>>>>       RedSurface *surface;
>>
>>
>> This introduces a 'surface' argument while retaining the local 'surface'
>> variable. That doesn't really make sense. Either this commit should only
>> change
>> the name (and not the parameters) or we should merge it with the next
>> commit.
>
>
> Furthermore, the function still uses surface_id.
>
>

I completely messed up with this split. Having the patch on its
original state was a better option.