[Spice-devel] [PATCH spice-common v2] m4: Add macro for --with-sasl

[Christophe Fergeau]

On Thu, Nov 26, 2015 at 03:59:56PM +0200, Uri Lublin wrote:
> On 11/26/2015 03:46 PM, Pavel Grunt wrote:
> >Hi Uri,
> >
> >On Thu, 2015-11-26 at 15:26 +0200, Uri Lublin wrote:
> >>On 11/26/2015 09:53 AM, Pavel Grunt wrote:
> >>>It is not used by spice-common, but both server and client can use it.
> >>>Compared to current checks in spice-gtk and spice server this macro only
> >>>supports libsasl2.
> >>>---
> >>>v2: - only supports libsasl2
> >>>      - PKG_CHECK_MODULES is used instead of AC_CHECK_LIB and AC_CHECK_HEADER
> >>>---
> >>
> >>Hi Pavel,
> >>
> >>Looks good to me.
> >>
> >>Did you try converting spice-server and spice-gtk to use this macro?
> >
> >I will send the patches (basically no change to the v1 http://lists.freedesktop.
> >org/archives/spice-devel/2015-November/024182.html ). The problem is that
> >libsasl2.pc file is not available for rhel6. So using this macro would disable
> >SASL on rhel6 clients and hosts.
> 
> That's a problem indeed.

When a .pc file can't be found, the pkg-config macros let you the
opportunity to set SASL_CFLAGS/SASL_LIBS in your environment to bypass
the check. Hopefully this works on EL6 too and can be used there if
needed. Alternatively, we can just revert that patch in EL6, not a huge
issue imo.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151127/75bcb888/attachment-0001.sig>