[Spice-devel] [PATCH 1/1] channel: add optional tcp keepalive timeout to channels

[Christophe Fergeau]

Hey,

On Fri, Nov 27, 2015 at 02:45:07PM +0900, Sunny Shin wrote:
> Hi,
> 
> With firewall running between spice server and client, if idle time is
> larger than firewall session timeout, spice sessions freeze and users lose
> their keyboard and mouse control.
> 
> To workaround this issue, I made a patch to add tcp keepalive timeout to
> spice server. The timeout can be added to qemu config like below.
>     <domain type='kvm' xmlns:qemu='
> http://libvirt.org/schemas/domain/qemu/1.0'>
>       <qemu:commandline>
>         <qemu:env name='SPICE_KEEPALIVE_TIMEOUT' value='1800'/>
>       </qemu:commandline>
> 
> I wanted to add this option to spice client, but there was no setsockopt()
> option of TCP_KEEPIDLE for windows platform, So, I ended up adding it to
> spice server. Please review the patch and let me know what you think. Thank
> you.

Thanks a lot for working on this! To do it client side, it looks like
https://msdn.microsoft.com/en-us/library/windows/desktop/dd877220%28v=vs.85%29.aspx
would need to be used. This would need to be added to glib, and then
used by the client.
Doing this server-side is fine I think, but as David pointed out, this
should be a command line option:
qemu-system-x86_64 -spice port=5900,keepalive=1800
Can you update your patch to do that?

Thanks,

Christophoe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151127/9f3b6398/attachment-0001.sig>