[Spice-devel] [PATCH] demarshall: Add safe method for unaligned byte access.

[Christophe Fergeau]

On Wed, Nov 25, 2015 at 09:04:58AM -0500, Frediano Ziglio wrote:
> > 
> > Usefull for ARM. Enable with "USE_MEMCPY" define.
> >  Should be better to add "--use-memcpy" to configure.ac
> > 
> > Signed-off-by: Anton D. Kachalov <mouse at yandex-team.ru>
> 
> Are you sure there are not other way except memcpy?

An alternate way which I proposed was to do
uint16_t my_int = unaligned_int[0] | unaligned_int[1] << 8
but Anton said it was likely to be slower than a memcpy. I don't know
how these unaligned accesses are usually handled in ARM code.
I found
https://github.com/yura-pakhuchiy/snappy-c/commit/a33077391874b36fb4c430ff9ed5f6e437b65f6f
doinng something similar, but that's about it.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151127/7d63bcb2/attachment.sig>