[Spice-devel] [spice-common 5/7] log: Kill spice_warn_if

[Jonathon Jongsma]

On Fri, 2015-11-27 at 16:47 +0100, Christophe Fergeau wrote:
> It's redundant with spice_warn_if_fail(), and can even be confusing.

Agreed. I assume you've checked to make sure nobody is actually using this?


> ---
>  common/log.h | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/common/log.h b/common/log.h
> index 6fecf66..2731582 100644
> --- a/common/log.h
> +++ b/common/log.h
> @@ -95,13 +95,7 @@ void spice_log(const char *log_domain,
>      }                                                   \
>  } G_STMT_END
>  
> -#define spice_warn_if(x) G_STMT_START {             \
> -    if SPICE_UNLIKELY(x) {                              \
> -        spice_warning("condition `%s' reached", #x);    \
> -    }                                                   \
> -} G_STMT_END
> -
> -#define spice_assert(x) G_STMT_START {                  \
> +#define spice_assert(x) G_STMT_START {              \

Any reason to change indentation here?

>      if SPICE_LIKELY(x) { } else {                       \
>          spice_error("assertion `%s' failed", #x);       \
>      }                                                   \


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>