[Spice-devel] [spice-common v2 5/7] log: Kill spice_warn_if

Christophe Fergeau cfergeau at redhat.com
Mon Nov 30 03:56:25 PST 2015


It's redundant with spice_warn_if_fail(), and can even be confusing.

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
---
No changes since v1 (apart from rebasing on top of the earlier changes)

 common/log.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/common/log.h b/common/log.h
index 99fc73b..c7e6e57 100644
--- a/common/log.h
+++ b/common/log.h
@@ -95,12 +95,6 @@ void spice_log(const char *log_domain,
     }                                                   \
 } G_STMT_END
 
-#define spice_warn_if(x) G_STMT_START {                 \
-    if G_UNLIKELY(x) {                                  \
-        spice_warning("condition `%s' reached", #x);    \
-    }                                                   \
-} G_STMT_END
-
 #define spice_assert(x) G_STMT_START {                  \
     if G_LIKELY(x) { } else {                           \
         spice_error("assertion `%s' failed", #x);       \
-- 
2.5.0



More information about the Spice-devel mailing list