[Spice-devel] [PATCH] proxy: support ipv6 addresses in brackets

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Oct 5 07:06:20 PDT 2015



> On October 5, 2015 at 2:53 PM Victor Toso <lists at victortoso.com> wrote:

> Could you please also add some tests in tests/session.c ?
> We are lacking tests and this seems a good oportunity ;)

Sure, apparently spice_uri_create in spice-session.c fails to add brackets when
needed, and I didn't see spice_uri_to_string either at first. Though I'm
wondering if those two sets of URI parsers shouldn't be unified somehow anyway.
Then again I've seen a GUri patch floating around (though I doubt it'll be
adopted very quickly...).
(This one:
http://lists.freedesktop.org/archives/spice-devel/2015-March/019288.html )

Going to send v2 in a bit.



More information about the Spice-devel mailing list