[Spice-devel] [PATCH v2 00/13] libcacard: pending patches

marcandre.lureau at redhat.com marcandre.lureau at redhat.com
Fri Oct 9 09:15:53 PDT 2015


From: Marc-André Lureau <marcandre.lureau at redhat.com>

A series of pending patches for libcacard, adapted from previous
patches for qemu. Most of this patches have already been reviewed by
me, other adapted, or added. A second look is worth it:

- add error checking to vcard_emul_options()
- add VCARD_DIRECT implementation to provide direct communication with
  a smartcard using libpcsclite (--enable-pcsc)
- bug fix: delete the reader entry after queueing an event, not before
- add a top-level libcacard.h header
- add test & code coverage
- update for 2.5.1

v1->v2:
- fixes after Christophe review
- made capcsc.h a private header
- updated autoconf-archive m4 files

thanks

Jeremy White (5):
  Bug fix: delete the reader entry after queueing an event, not before
  Add error checking to vcard_emul_options()
  Add a VCARD_DIRECT implemention to the libcacard smartcard support
  Enable support for passthru
  vscclient: remove the (broken) passthru option

Marc-André Lureau (7):
  build-sys: update autoconf-archive macros
  build-sys: add --enable-pcsc
  build-sys: do not install vcardt_internal.h
  Add libcacard.h
  Add some tests & code coverage
  build-sys: move G_LOG_DOMAIN to CPPFLAGS
  NEWS: update for upcoming 2.5.1

Thomas Huth (1):
  libcacard: Fix bug detected with 'smatch'

 Makefile.am                     |  42 ++-
 NEWS                            |  11 +
 build-aux/glib-tap.mk           | 150 +++++++++
 build-aux/tap-driver.sh         | 652 ++++++++++++++++++++++++++++++++++++++++
 build-aux/tap-test              |   5 +
 configure.ac                    |  29 ++
 m4/ax_append_flag.m4            |   4 +-
 m4/ax_compiler_flags.m4         |   4 +-
 m4/ax_compiler_flags_cflags.m4  |   7 +-
 m4/ax_compiler_flags_ldflags.m4 |  12 +-
 m4/glibtests.m4                 |  28 ++
 src/capcsc.c                    | 501 ++++++++++++++++++++++++++++++
 src/capcsc.h                    |  18 ++
 src/card_7816.c                 |   8 +-
 src/card_7816.h                 |   4 +-
 src/libcacard.h                 |  21 ++
 src/libcacard.syms              |   1 +
 src/vcard.c                     |   2 +-
 src/vcard.h                     |   2 +-
 src/vcard_emul_nss.c            |  76 ++++-
 src/vcard_emul_type.c           |   3 +-
 src/vreader.c                   |   7 +-
 src/vscclient.c                 |  16 +-
 tests/db/cert8.db               | Bin 0 -> 65536 bytes
 tests/db/key3.db                | Bin 0 -> 16384 bytes
 tests/db/secmod.db              | Bin 0 -> 16384 bytes
 tests/libcacard.c               | 239 +++++++++++++++
 27 files changed, 1782 insertions(+), 60 deletions(-)
 create mode 100644 build-aux/glib-tap.mk
 create mode 100755 build-aux/tap-driver.sh
 create mode 100755 build-aux/tap-test
 create mode 100644 m4/glibtests.m4
 create mode 100644 src/capcsc.c
 create mode 100644 src/capcsc.h
 create mode 100644 src/libcacard.h
 create mode 100644 tests/db/cert8.db
 create mode 100644 tests/db/key3.db
 create mode 100644 tests/db/secmod.db
 create mode 100644 tests/libcacard.c

-- 
2.4.3



More information about the Spice-devel mailing list