[Spice-devel] [PATCH v2 07/13] vscclient: remove the (broken) passthru option

[Marc-André Lureau]

Hi

----- Original Message -----
> On Fri, Oct 09, 2015 at 06:16:00PM +0200, marcandre.lureau at redhat.com wrote:
> > From: Jeremy White <jwhite at codeweavers.com>
> > 
> > That option can be achieved using -e "use_hw=yes hw_type=passthru"
> 
> Any idea why this is called "broken" by the way? Might be worth to
> expand a bit on the exact meaning of 'broken' ? (crash, not doing
> anything, cannot work because of XXX or YYY, ...).

Ok, I'll add a comment (it was not implemented)

> 
> Christophe
> 
> > 
> > Signed-off-by: Jeremy White <jwhite at codeweavers.com>
> > Reviewed-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  src/vscclient.c | 16 +++-------------
> >  1 file changed, 3 insertions(+), 13 deletions(-)
> > 
> > diff --git a/src/vscclient.c b/src/vscclient.c
> > index e9fd3aa..dd20842 100644
> > --- a/src/vscclient.c
> > +++ b/src/vscclient.c
> > @@ -49,14 +49,8 @@ print_byte_array(
> >  
> >  static void
> >  print_usage(void) {
> > -    printf("vscclient [-c <certname> .. -e <emul_args> -d <level>%s] "
> > -            "<host> <port>\n",
> > -#ifdef USE_PASSTHRU
> > -    " -p");
> > -    printf(" -p use passthrough mode\n");
> > -#else
> > -   "");
> > -#endif
> > +    printf("vscclient [-c <certname> .. -e <emul_args> -d <level>] "
> > +            "<host> <port>\n");
> >      vcard_emul_usage();
> >  }
> >  
> > @@ -684,7 +678,7 @@ main(
> >      }
> >  #endif
> >  
> > -    while ((c = getopt(argc, argv, "c:e:pd:")) != -1) {
> > +    while ((c = getopt(argc, argv, "c:e:d:")) != -1) {
> >          switch (c) {
> >          case 'c':
> >              if (cert_count >= MAX_CERTS) {
> > @@ -696,10 +690,6 @@ main(
> >          case 'e':
> >              emul_args = optarg;
> >              break;
> > -        case 'p':
> > -            print_usage();
> > -            exit(4);
> > -            break;
> >          case 'd':
> >              verbose = get_id_from_string(optarg, 1);
> >              break;
> > --
> > 2.4.3
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
>