[Spice-devel] [NSIS 8/8] packaging: add Makefile

[Yedidyah Bar David]

On Mon, Sep 14, 2015 at 4:24 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Sun, Sep 13, 2015 at 08:50:22AM +0300, Yedidyah Bar David wrote:
>> > same content as what would be generated by git archive, just working also
>> > without the .git.
>>
>> Not sure it should be part of 'make dist', but I think it will help if we
>> also have somewhere the git hash inside the tarball/build/iso image/installed
>> apps. Not sure what's the best place to put this into. To do that we do need
>> .git .
>
> There exists some magic to do this kind of things without needing the
> .git directory. This is used by spice-gtk for example, make dist on an
> untagged git commit will generate a tarball whose name contains the git
> hash, make dist on a tagged git commit will generate a tarball with just
> the version number.

spice-gtk uses git-version-gen, apparently copied from an older version of
gnulib [1]. Do we want to copy it from there? Their master branch version?
It went through some changes there since [1].

There are some non-trivial (to me) things related to copying such things
around, not sure how much of it is really relevant in such a simple case.
See e.g. [2], [3] and [4], which means this is currently in a middle of a
change.

Also, do we want a configure script (and autotools)? Or is Makefile enough?

[1] http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=e0fcde8130473202a4dd37c41a3c331fc5a9907d
[2] http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=configure.ac;h=fc1a0526bd68b0a627075303ea01b8bd58561d90;hb=HEAD
[3] https://bugzilla.redhat.com/show_bug.cgi?id=821748
[4] https://fedorahosted.org/fpc/ticket/575

Best,
-- 
Didi