[Spice-devel] [PATCH v2 3/3] tests/session: test ipv6 uri and proxy

Christophe Fergeau cfergeau at redhat.com
Mon Oct 12 09:08:12 PDT 2015


Hey,

On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> ---
>  tests/session.c | 45 +++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 39 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/session.c b/tests/session.c
> index feee3db..c9f6bca 100644
> --- a/tests/session.c
> +++ b/tests/session.c
> @@ -8,24 +8,28 @@ static void test_session_uri(void)
>      gint i;
>  
>      struct {
> +        gchar *host;
>          gchar *port;
>          gchar *tls_port;
>          gchar *uri_input;
>          gchar *uri_output;
>      } tests[] = {
>          /* Arguments with empty value */
> -        { "5900", NULL,
> +        { "localhost", "5900", NULL,
>            "spice://localhost?port=5900&tls-port=",
>            "spice://localhost?port=5900&" },
> -        { "5910", NULL,
> +        { "localhost", "5910", NULL,
>            "spice://localhost?tls-port=&port=5910",
>            "spice://localhost?port=5910&" },
> -        { NULL, "5920",
> +        { "localhost", NULL, "5920",
>            "spice://localhost?tls-port=5920&port=",
>            "spice://localhost?tls-port=5920" },
> -        { NULL, "5930",
> -          "spice://localhost?port=&tls-port=5930",
> -          "spice://localhost?tls-port=5930" },
> +        { "127.0.0.1", NULL, "5930",
> +          "spice://127.0.0.1?port=&tls-port=5930",
> +          "spice://127.0.0.1?tls-port=5930" },
> +        { "::1", NULL, "5940",
> +          "spice://[::1]?port=&tls-port=5940",
> +          "spice://[::1]?tls-port=5940" },
>      };

Was this test working fine for you ? most of the tests in tests/ were
not building for me, I get runtime warnings when empty port= or
tls-port= values are passed, ...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151012/9b111b0c/attachment.sig>


More information about the Spice-devel mailing list