[Spice-devel] [PATCH v5 20/20] spice-gtk: Use typefind and decodebin as fallbacks to set up the GStreamer pipeline.

[Francois Gouget]

On Mon, 21 Sep 2015, Christophe Fergeau wrote:
[...]
> > +        src_caps = "typefind=true"; /* Misidentifies VP8 */
> 
> What does VP8 gets identified as when using this? Has this been reported
> to gstreamer developers?

With GStreamer 1.6.0 typefind does not identify it at all (with 
GStreamer 0.10 I believe it mistook it for something else). I reported 
the GStreamer 1.0 issue this but it does not seem like this is a use 
case the GStreamer developers care about: 
https://bugzilla.gnome.org/show_bug.cgi?id=756457


> > +    }
> > +    if (!gstdec_name || gst_auto) {
> > +        gstdec_name = "decodebin";  /* vaapi is assert-happy */
> 
> Does this comment mean that gstreamer is going to pick vaapi if
> available when decodebin is present?

Yes.

> Have you reported the crashes you got upstream?

I did and it got fixed recently. It will be some time before the fix is 
widely disseminated though.
https://bugs.freedesktop.org/show_bug.cgi?id=90884


> Are these bugs the only reason why you are using fixed pipelines for 
> VP8/H264 rather than always using decodebin?

Yes. At this point relying on typefind and/or decodebin does not seem 
reliable enough.


-- 
Francois Gouget <fgouget at codeweavers.com>