[Spice-devel] [PATCH v2 2/3] session: spice_uri_create put brackets around ipv6 addresses

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Oct 13 00:36:49 PDT 2015


> On October 12, 2015 at 6:16 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
> 
> Looks good, though detecting the presence of ":" feels a bit magic :)

Surely it's a future proof strategy because who uses colons for anything
meaningful anyway? ;-)
At least s->host is supposed to only contain the host and no other parts like
`:port` AFAIK, so it should do, until the next IP version comes out where
they'll probably use the next perfectly compatible sign that doesn't break any
other addressing scheme. You know, like an '@' or a slash ;-)



More information about the Spice-devel mailing list