[Spice-devel] [PATCH v2 3/3] tests/session: test ipv6 uri and proxy

[Victor Toso]

Hi,

On Tue, Oct 13, 2015 at 09:31:11AM +0200, Christophe Fergeau wrote:
> Ah ok, good that we are seeing the same behaviour :) Fwiw, the warnings
> are avoided with:
>
> diff --git a/tests/session.c b/tests/session.c
> index 0b57e7e..aecc009 100644
> --- a/tests/session.c
> +++ b/tests/session.c
> @@ -16,19 +16,19 @@ static void test_session_uri(void)
>      } tests[] = {
>          /* Arguments with empty value */

The above argument does not imply that those tests are correct?

>          { "localhost", "5900", NULL,
> -          "spice://localhost?port=5900&tls-port=",
> +          "spice://localhost?port=5900",
>            "spice://localhost?port=5900&" },
>          { "localhost", "5910", NULL,
> -          "spice://localhost?tls-port=&port=5910",
> +          "spice://localhost?port=5910",
>            "spice://localhost?port=5910&" },
>          { "localhost", NULL, "5920",
> -          "spice://localhost?tls-port=5920&port=",
> +          "spice://localhost?tls-port=5920",
>            "spice://localhost?tls-port=5920" },
>          { "127.0.0.1", NULL, "5930",
> -          "spice://127.0.0.1?port=&tls-port=5930",
> +          "spice://127.0.0.1?tls-port=5930",
>            "spice://127.0.0.1?tls-port=5930" },
>          { "::1", NULL, "5940",
> -          "spice://[::1]?port=&tls-port=5940",
> +          "spice://[::1]?tls-port=5940",
>            "spice://[::1]?tls-port=5940" },
>      };
>
> I can send that as a proper git patch on top of your changes if you want, or
> feel free to integrate this in your series.
>
> Christophe

It is common to remote-viewer/spicy attach empty tls argument and IIRC
that was buggy at some point.

cheers,
  toso