[Spice-devel] [spice-gtk] build-sys:tests: Error out unless --enable-static is used

[Victor Toso]

Hey,

On Tue, Oct 13, 2015 at 10:56:00AM +0200, Christophe Fergeau wrote:
> The binaries in tests/ need a static build of spice-gtk libraries in
> order to be built, but by default, we disable static libraries at
> LT_INIT() time.
> As the compile failure can be quite cryptic when someone
> tries to manually run 'make -C tests', this commit adds an explicit
> error message when trying to build the tests without --enable-static.
> ---
>  tests/Makefile.am | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 19c02b6..144bc38 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1,3 +1,6 @@
> +if !BUILD_TESTS
> +$(error Building tests requires using --enable-static)
> +endif
>  NULL =
>
>  noinst_PROGRAMS =				\
> --
> 2.5.0

ack as well.

I really don't understand why we do tests on when --enable-static only.
Personally I prefer --enable-debug and do the linking...

http://lists.freedesktop.org/archives/spice-devel/2015-February/019049.html