[Spice-devel] [spice-gtk PATCH v1 2/2] tests: build sources to each test

Christophe Fergeau cfergeau at redhat.com
Wed Oct 14 03:28:41 PDT 2015


On Wed, Oct 14, 2015 at 12:15:16PM +0200, Victor Toso wrote:
> ---
>  tests/Makefile.am | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 19c02b6..e28f880 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -25,10 +25,31 @@ LDADD =							\
>  	$(top_builddir)/src/libspice-client-glib-2.0.la	\
>  	$(NULL)
>  
> -util_SOURCES = util.c
> +util_SOURCES =			\
> +	util.c			\
> +	../src/spice-util.c
> +
>  coroutine_SOURCES = coroutine.c
> +
> +if WITH_UCONTEXT
> +coroutine_SOURCES += 				\
> +	../src/continuation.c 			\
> +	../src/coroutine_ucontext.c
> +endif
> +
> +if WITH_WINFIBER
> +coroutine_SOURCES += coroutine_winfibers.c
> +endif
> +
> +if WITH_GTHREAD
> +coroutine_SOURCES += coroutine_gthread.c
> +endif
> +

As I mentioned before, duplicating this logic here is not very nice (but
I can live with it).
Maybe --enable-tests shoud just enable static builds when specified?

>  session_SOURCES = session.c
> -pipe_SOURCES = pipe.c
> +
> +pipe_SOURCES =			\
> +	pipe.c			\
> +	../src/giopipe.c

Needs to be $(top_srcdir) I think.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151014/e53401ba/attachment.sig>


More information about the Spice-devel mailing list