[Spice-devel] [PATCH 5/6] Remove ACYCLIC_SURFACE_DEBUG

Frediano Ziglio fziglio at redhat.com
Thu Oct 15 03:54:24 PDT 2015


From: Marc-André Lureau <marcandre.lureau at gmail.com>

---
 server/red_worker.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index ce96449..9ed54f5 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -100,7 +100,6 @@
 /* TODO: DRAW_ALL is broken. */
 //#define DRAW_ALL
 //#define COMPRESS_DEBUG
-//#define ACYCLIC_SURFACE_DEBUG
 //#define DEBUG_CURSORS
 
 #define CMD_RING_POLL_TIMEOUT 10 //milli
@@ -895,9 +894,6 @@ typedef struct RedSurface {
     uint32_t refs;
     Ring current;
     Ring current_list;
-#ifdef ACYCLIC_SURFACE_DEBUG
-    int current_gn;
-#endif
     DrawContext context;
 
     Ring depend_on_me;
@@ -4637,9 +4633,6 @@ static void red_update_area(RedWorker *worker, const SpiceRect *area, int surfac
     QRegion rgn;
     Drawable *last;
     Drawable *now;
-#ifdef ACYCLIC_SURFACE_DEBUG
-    int gn;
-#endif
     spice_debug("surface %d: area ==>", surface_id);
     rect_debug(area);
 
@@ -4651,9 +4644,6 @@ static void red_update_area(RedWorker *worker, const SpiceRect *area, int surfac
     surface = &worker->surfaces[surface_id];
 
     last = NULL;
-#ifdef ACYCLIC_SURFACE_DEBUG
-    gn = ++surface->current_gn;
-#endif
     ring = &surface->current_list;
     ring_item = ring;
 
@@ -4684,11 +4674,6 @@ static void red_update_area(RedWorker *worker, const SpiceRect *area, int surfac
         container_cleanup(worker, container);
         red_draw_drawable(worker, now);
         release_drawable(worker, now);
-#ifdef ACYCLIC_SURFACE_DEBUG
-        if (gn != surface->current_gn) {
-            spice_error("cyclic surface dependencies");
-        }
-#endif
     } while (now != last);
     validate_area(worker, area, surface_id);
 }
-- 
2.4.3



More information about the Spice-devel mailing list