[Spice-devel] [PATCH] Remove DRAW_ALL

[Frediano Ziglio]

Acked

As stated in the comment was not even working anymore

----- Original Message -----
> From: "Frediano Ziglio" <fziglio at redhat.com>
> To: spice-devel at lists.freedesktop.org
> Sent: Friday, October 16, 2015 1:24:44 PM
> Subject: [Spice-devel] [PATCH] Remove DRAW_ALL
> 
> From: Marc-André Lureau <marcandre.lureau at gmail.com>
> 
> ---
>  server/red_worker.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 147c679..e8a1e10 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -96,10 +96,7 @@
>  //#define COMPRESS_STAT
>  //#define DUMP_BITMAP
>  //#define RED_WORKER_STAT
> -/* TODO: DRAW_ALL is broken. */
> -//#define DRAW_ALL
>  //#define COMPRESS_DEBUG
> -//#define DEBUG_CURSORS
>  
>  #define CMD_RING_POLL_TIMEOUT 10 //milli
>  #define CMD_RING_POLL_RETRIES 200
> @@ -983,15 +980,10 @@ typedef struct BitmapData {
>  static inline int validate_surface(RedWorker *worker, uint32_t surface_id);
>  static void red_draw_qxl_drawable(RedWorker *worker, Drawable *drawable);
>  static void red_current_flush(RedWorker *worker, int surface_id);
> -#ifdef DRAW_ALL
> -#define red_update_area(worker, rect, surface_id)
> -#define red_draw_drawable(worker, item)
> -#else
>  static void red_draw_drawable(RedWorker *worker, Drawable *item);
>  static void red_update_area(RedWorker *worker, const SpiceRect *area, int
>  surface_id);
>  static void red_update_area_till(RedWorker *worker, const SpiceRect *area,
>  int surface_id,
>                                   Drawable *last);
> -#endif
>  static void red_release_cursor(RedWorker *worker, CursorItem *cursor);
>  static inline void release_drawable(RedWorker *worker, Drawable *item);
>  static void red_display_release_stream(RedWorker *worker, StreamAgent
>  *agent);
> @@ -4005,9 +3997,6 @@ static inline void red_process_drawable(RedWorker
> *worker, RedDrawable *red_draw
>              worker->transparent_count++;
>          }
>          red_pipes_add_drawable(worker, drawable);
> -#ifdef DRAW_ALL
> -        red_draw_qxl_drawable(worker, drawable);
> -#endif
>      }
>  cleanup:
>      release_drawable(worker, drawable);
> @@ -4289,8 +4278,6 @@ static void red_draw_qxl_drawable(RedWorker *worker,
> Drawable *drawable)
>      }
>  }
>  
> -#ifndef DRAW_ALL
> -
>  static void red_draw_drawable(RedWorker *worker, Drawable *drawable)
>  {
>      red_flush_source_surfaces(worker, drawable);
> @@ -4454,8 +4441,6 @@ static void red_update_area(RedWorker *worker, const
> SpiceRect *area, int surfac
>      validate_area(worker, area, surface_id);
>  }
>  
> -#endif
> -
>  static inline void free_cursor_item(RedWorker *worker, CursorItem *item);
>  
>  static void red_release_cursor(RedWorker *worker, CursorItem *cursor)