[Spice-devel] [PATCH] fix spelling mistakes in comments (reseting to resetting & dummym to dummy)

[Christophe Fergeau]

Hey,

This has been pushed already, but 2 cosmetic comments:
- you might want to capitalize your first/last name (Snir Sheriber
  rather than snir sheriber)
- it's better to keep the short log (first line of the commit log) short
  (60 characters or so) as this makes things more readable in various
  tools (git log --format=oneline, tig, ...). In this commit, you could
  have moved the description of the typoes you fixed in the longer log
  (starting at the 3rd line)
- and I would have capitalized the first line of the short log as well

These are all minor details, thanks for that first patch!

Christophe

On Sun, Oct 18, 2015 at 10:51:56AM +0300, snir sheriber wrote:
> ---
>  server/glz_encoder_dictionary.c | 2 +-
>  server/red_channel.c            | 4 ++--
>  server/red_worker.c             | 2 +-
>  server/reds.c                   | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/server/glz_encoder_dictionary.c b/server/glz_encoder_dictionary.c
> index ba6065f..70226e1 100644
> --- a/server/glz_encoder_dictionary.c
> +++ b/server/glz_encoder_dictionary.c
> @@ -289,7 +289,7 @@ static void __glz_dictionary_window_segs_realloc(SharedDictionary *dict)
>      memcpy(new_segs, dict->window.segs,
>             sizeof(WindowImageSegment) * dict->window.segs_quota);
>  
> -    // reseting the new elements
> +    // resetting the new elements
>      for (i = dict->window.segs_quota, seg = new_segs + i; i < new_quota; i++, seg++) {
>          seg->image = NULL;
>          seg->lines = NULL;
> diff --git a/server/red_channel.c b/server/red_channel.c
> index 3f40fab..3f6240a 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -455,7 +455,7 @@ static void red_channel_client_reset_send_data(RedChannelClient *rcc)
>      rcc->send_data.header.set_msg_type(&rcc->send_data.header, 0);
>      rcc->send_data.header.set_msg_size(&rcc->send_data.header, 0);
>  
> -    /* Keeping the serial consecutive: reseting it if reset_send_data
> +    /* Keeping the serial consecutive: resetting it if reset_send_data
>       * has been called before, but no message has been sent since then.
>       */
>      if (rcc->send_data.last_sent_serial != rcc->send_data.serial) {
> @@ -1088,7 +1088,7 @@ static void dummy_watch_remove(SpiceWatch *watch)
>  {
>  }
>  
> -// TODO: actually, since I also use channel_client_dummym, no need for core. Can be NULL
> +// TODO: actually, since I also use channel_client_dummy, no need for core. Can be NULL
>  SpiceCoreInterface dummy_core = {
>      .watch_update_mask = dummy_watch_update_mask,
>      .watch_add = dummy_watch_add,
> diff --git a/server/red_worker.c b/server/red_worker.c
> index babb597..5578be3 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -3063,7 +3063,7 @@ static void red_stream_update_client_playback_latency(void *opaque, uint32_t del
>      if (delay_ms > agent->dcc->streams_max_latency) {
>           agent->dcc->streams_max_latency = delay_ms;
>      }
> -    spice_debug("reseting client latency: %u", agent->dcc->streams_max_latency);
> +    spice_debug("resetting client latency: %u", agent->dcc->streams_max_latency);
>      main_dispatcher_set_mm_time_latency(agent->dcc->common.base.client, agent->dcc->streams_max_latency);
>  }
>  
> diff --git a/server/reds.c b/server/reds.c
> index 5d2ad9b..2aea688 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -401,7 +401,7 @@ static void reds_reset_vdp(void)
>      state->write_filter.discard_all = TRUE;
>      state->client_agent_started = FALSE;
>  
> -    /* reseting and not destroying the state as a workaround for a bad
> +    /* resetting and not destroying the state as a workaround for a bad
>       * tokens management in the vdagent protocol:
>       *  The client tokens' are set only once, when the main channel is initialized.
>       *  Instead, it would have been more appropriate to reset them upon AGEN_CONNECT.
> -- 
> 2.4.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151019/dbe8a471/attachment-0001.sig>