[Spice-devel] [usbredir PATCH v4 0/2] spice-gtk memleak with isochronous devices

Victor Toso victortoso at redhat.com
Wed Oct 21 03:38:10 PDT 2015


Addressing some of Hans comments but not all of them yet.

This versions sets a higher and lower threshold so usbredir can drop
*some* packages when we are above lower threshold and drop *all*
packages when we are above the higher threshold.

Hans, I'm failing to have the rate measurement for the isochronous
device. Could you give me some insights about it?

I would like to have your previous suggestion about dropping frames
based in time instead of size and having the actual rate of the device
seems necessary.

I also think that it makes sense to limit the queue size in spice-gtk
to the size of some length of the stream, lets say 3 seconds.

Thanks again for your help,

Victor Toso (2):
  usbredirhost: new callback for iso streams
  spice-channel: check message queue size

 usbredirhost/usbredirhost.c | 70 +++++++++++++++++++++++++++++++++++++++++++--
 usbredirhost/usbredirhost.h | 13 +++++++++
 2 files changed, 81 insertions(+), 2 deletions(-)

 src/channel-usbredir.c   | 43 +++++++++++++++++++++++++++++++++++++++++++
 src/spice-channel-priv.h |  2 ++
 src/spice-channel.c      | 19 ++++++++++++++++++-
 3 files changed, 63 insertions(+), 1 deletion(-)

-- 
2.5.0



More information about the Spice-devel mailing list