[Spice-devel] [PATCH 1/9] server/dispatcher: move worker enums to dispatcher header

Fabiano FidĂȘncio fabiano at fidencio.org
Wed Oct 21 12:12:12 PDT 2015


On Wed, Oct 21, 2015 at 2:26 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
>
>>
>> From: Marc-André Lureau <marcandre.lureau at gmail.com>
>>
>> Group enums with their respective struct location.
>> ---
>>  server/red_dispatcher.h | 97
>>  ++++++++++++++++++++++++++++++++++++++++++++++++-
>>  server/red_worker.h     | 93 +----------------------------------------------
>>  2 files changed, 96 insertions(+), 94 deletions(-)
>>
>> diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h
>> index 320b7e3..dbe65d1 100644
>> --- a/server/red_dispatcher.h
>> +++ b/server/red_dispatcher.h
>> @@ -18,10 +18,13 @@
>>  #ifndef _H_RED_DISPATCHER
>>  #define _H_RED_DISPATCHER
>>
>> +#include <errno.h>
>> +#include "spice_server_utils.h"
>
> Would be better to include unistd.h instead of spice_server_utils.h
> Beside that I would ack it

I also would go for a unistd.h include. Any of the other contents from
spice_server_utils.h is used here.

ACK with this change.


More information about the Spice-devel mailing list