[Spice-devel] [PATCH 0/9] Backported some patches from refactory branches (21th Oct)

Jonathon Jongsma jjongsma at redhat.com
Wed Oct 21 14:08:39 PDT 2015


On Wed, 2015-10-21 at 13:00 +0100, Frediano Ziglio wrote:
> These patches are extracted from a branch intended to refactory
> spice-server.
> 
> This patchset supersed last patchset and apply to updated master.


Can you provide a little bit of explanation for why this new set
supersedes the last set and what the differences are? It looks like you
dropped some patches and added others? Can you explain why? Are the
other patches identical to those in the previous set? There were
comments and unanswered questions on the previous patchset and then
nothing further until this email. Some additional context would make it
much easier to review.


> 
> Alon Levy (1):
>   server/red_worker: red_draw_qxl_drawable: protect from NULL
>     dereference in case of buggy driver (or recording)
> 
> Marc-André Lureau (8):
>   server/dispatcher: move worker enums to dispatcher header
>   server: remove worker thread creation from dispatcher
>   worker: remove useless MESSAGE_READY
>   server: dispatcher_init/dispatcher_new
>   worker: use a single clockid
>   worker: remove need for WorkerInitData
>   worker: use glib main loop
>   channel: do not free rcc->stream in red_channel_client_disconnect
> 
>  server/Makefile.am         |   2 -
>  server/dispatcher.c        |  13 +
>  server/dispatcher.h        |   2 +
>  server/red_channel.c       |  39 +--
>  server/red_dispatcher.c    | 127 +++-------
>  server/red_dispatcher.h    | 100 +++++++-
>  server/red_worker.c        | 579 +++++++++++++++++++++++++----------
> ----------
>  server/red_worker.h        | 129 +---------
>  server/reds.c              |  46 +++-
>  server/reds.h              |  16 ++
>  server/spice_timer_queue.c | 273 ---------------------
>  server/spice_timer_queue.h |  43 ----
>  12 files changed, 556 insertions(+), 813 deletions(-)
>  delete mode 100644 server/spice_timer_queue.c
>  delete mode 100644 server/spice_timer_queue.h
> 


More information about the Spice-devel mailing list